Skip to content

fix(login): prevent multiple error toasts on login by clearing previous toasts - #5312

Merged
Jonsy13 merged 3 commits into
litmuschaos:masterfrom
SharanRP:fix/login-toast-single
Dec 12, 2025
Merged

fix(login): prevent multiple error toasts on login by clearing previous toasts#5312
Jonsy13 merged 3 commits into
litmuschaos:masterfrom
SharanRP:fix/login-toast-single

Conversation

@SharanRP

@SharanRP SharanRP commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Proposed changes

Clear existing error toasts before showing a new login error.
This prevents many identical error messages from stacking when a user clicks "Sign In" repeatedly.
closes #5308

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@PriteshKiri

Copy link
Copy Markdown
Contributor

Hey @SharanRP

Thanks for raising the PR.

It looks good!! Could you just share the video for the fix?

@SharanRP

Copy link
Copy Markdown
Contributor Author
AwesomeScreenshot-11_22_2025.11_50_39PM.webm

@PriteshKiri @amityt

@Jonsy13
Jonsy13 merged commit 07b6a2c into litmuschaos:master Dec 12, 2025
17 of 18 checks passed
Calvinaud pushed a commit to Calvinaud/litmus that referenced this pull request Apr 21, 2026
…us toasts (litmuschaos#5312)

Signed-off-by: SharanRP <z8903830@gmail.com>
Co-authored-by: Pritesh Kiri <77957844+PriteshKiri@users.noreply.github.com>
Co-authored-by: Amit Kumar Das <amit.das@harness.io>
Signed-off-by: Calvin Audier <calvin.audier@amadeus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error toasts stack vertically on login page

4 participants