Skip to content

CICD: bumped GHA versions#145

Merged
lissy93 merged 1 commit into
lissy93:masterfrom
vitalykarasik:CICD/gha-updates
May 26, 2024
Merged

CICD: bumped GHA versions#145
lissy93 merged 1 commit into
lissy93:masterfrom
vitalykarasik:CICD/gha-updates

Conversation

@vitalykarasik
Copy link
Copy Markdown
Contributor

Updated GitHub Actions versions (current versions use outdated Node runtime and other deprecated features)

@netlify
Copy link
Copy Markdown

netlify Bot commented May 24, 2024

Deploy Preview for web-check ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 17696d8
🔍 Latest deploy log https://app.netlify.com/sites/web-check/deploys/6650083bc520bf0008f3a365
😎 Deploy Preview https://deploy-preview-145--web-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Owner

@lissy93 lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vitalykarasik
Just testing atm, did you verify these all worked, as it looks like some of those (like docker/build-push-action) had API changes the affect which parameters are needed?

@vitalykarasik
Copy link
Copy Markdown
Contributor Author

Thanks @vitalykarasik Just testing atm, did you verify these all worked, as it looks like some of those (like docker/build-push-action) had API changes the affect which parameters are needed?

@lissy93 - To say the truth I didn't test end-to-end because it's tricky without your credentials. At a glance, it seems that there are no breaking changes.
If you agree, I'll add a new trigger to https://github.com/Lissy93/web-check/blob/master/.github/workflows/docker.yml to activate this workflow on PR to master, not only on push - for test e2e. Please suggest.

Copy link
Copy Markdown
Owner

@lissy93 lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally, and it seems to be working, I'll go ahead and merge and watch closely to make sure it all still works.

Thanks again @vitalykarasik - appreciate your PR :)

@lissy93 lissy93 merged commit fd49c48 into lissy93:master May 26, 2024
@vitalykarasik
Copy link
Copy Markdown
Contributor Author

I've tested locally, and it seems to be working, I'll go ahead and merge and watch closely to make sure it all still works.

Thanks again @vitalykarasik - appreciate your PR :)

Thank you! Please ping me if you see any issues with CI/CD or want to improve it.

@vitalykarasik
Copy link
Copy Markdown
Contributor Author

I suspect we should revert - I see a few issues with the latest runs. @lissy93

chrnorm/deployment-status@ - probably related to upgrade

node16 deprecation during "aws deploy" - I'm not sure why, node16 is still supported for a 2 weeks - https://docs.aws.amazon.com/lambda/latest/dg/lambda-nodejs.html

aristech pushed a commit to aristech/web-check that referenced this pull request Jan 7, 2026
Kslnicky pushed a commit to OSINT-NKG/web-check that referenced this pull request Jan 13, 2026
Kslnicky pushed a commit to OSINT-NKG/web-check that referenced this pull request Jan 15, 2026
SmartMur pushed a commit to SmartMur/web-check that referenced this pull request Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants