Support MiniMax M3 CPU KVStore - #758
Draft
FlamingoPg wants to merge 1 commit into
Draft
Conversation
Signed-off-by: FlamingoPg <1106310035@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
MiniMax M3 stores an additional
index_k_bufferfor each sparse-attention layer. The flat host mirror previously transferred only K/V and recurrent state, so an L2 loadback restored K/V but left the MSA index cache stale. Host-page sizing also omitted roughly 47.5% of M3's per-rank cache bytes.The flat mirror now supports a model-neutral, layer-aligned auxiliary page-buffer protocol. M3 publishes its index-key pages through that protocol; the generic executor does not contain a MiniMax-specific branch.
Validation
pre-commit run --all-filesCUDA_VISIBLE_DEVICES=4 PYTHONPATH=python:tokenspeed-kernel/python .venv/bin/python -m pytest -q test/runtime/test_flat_host_mirror.py test/runtime/test_flat_host_executor.py test/runtime/models/test_minimax_m3.py26 passed--max-total-tokens 8192 --max-model-len 4096 --block-size 128 --kvstore-ratio 2.0 --enforce-eager129pages ×5,799,936bytes/page per rank0 / 12,288cached tokens2,944 / 3,072cached tokens for each of four prompts (95.83%)WriteBackDoneEventandLoadBackDoneEvent