Desktop: Whiteboard: Place new groups in empty space instead of viewport centre - #15901
Merged
Conversation
coderabbitai
Bot
added
desktop
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New groups used to spawn dead-centre at a fixed 480×400, often on top of existing nodes — which then became captives of the group and had to be dragged out before the group could be moved.
Now the placement searches for an empty spot near the viewport centre, spiralling outward and shrinking from a preferred 320×240 down to a 100×100 minimum. If nothing fits in view, the group is placed adjacent to the existing-nodes bounding box (with a gap) on whichever side is closest to the viewport, so it stays partially visible.
Logic is extracted to packages/lib/services/whiteboard/findEmptySpot.ts with unit tests.