Skip to content

Desktop: Resolves #15763: Reveal markup on mouseup instead of mousedown - #15778

Merged
laurent22 merged 3 commits into
laurent22:devfrom
Rygaa:issue15763
Jul 2, 2026
Merged

Desktop: Resolves #15763: Reveal markup on mouseup instead of mousedown#15778
laurent22 merged 3 commits into
laurent22:devfrom
Rygaa:issue15763

Conversation

@Rygaa

@Rygaa Rygaa commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Resolves #15763

I changed inline markup show from mousedown to mouseup. The cursor issue was not caused by mousedown.

Another issue: hidden link text was selected by accident. For [Joplin website](https://joplinapp.org), user sees only Joplin website, but CodeMirror sees full Markdown. Small mouse move could select hidden end part, like [Joplin website|](https://joplinapp.org)|. After Markdown was shown, hidden selection became highlighted text. Fix: on mouseup, if selected text is only hidden text, change it back to one cursor before showing Markdown.

Another issue: cursor did not go to the link end. After the hidden-selection fix, clicking at the end of shown Joplin website could still leave cursor before hidden link end: [Joplin website|](https://joplinapp.org). Fix: only for that end-click case, move cursor to full link end: [Joplin website](https://joplinapp.org)|. Middle click still stays inside link text.

Another issue: I also fixed links with space after (, like [label]( url). That space stayed visible while URL was hidden, so end click could put cursor near ( or URL. Fix: hide that space with URL.

Screen.Recording.2026-06-26.at.11.38.48.PM.mov

@coderabbitai coderabbitai Bot added bug It's a bug editor markdown-editor About the Markdown editor labels Jun 27, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@joplin-coderabbit-cleanup joplin-coderabbit-cleanup Bot deleted a comment from coderabbitai Bot Jun 27, 2026
@bwat47

bwat47 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

I noticed one minor issue with selections, where when the markup reveals on mouseup, the selection is sometimes missing the markdown formatting characters (even though the selection covered the entire word):

Screencast.From.2026-06-27.08-03-19.mp4

edit: there can also be flickering during click and drag when the selection starts with hidden markdown formatting:

Screencast.From.2026-06-27.10-13-26.mp4

@joplin-coderabbit-cleanup joplin-coderabbit-cleanup Bot deleted a comment from coderabbitai Bot Jun 28, 2026
@Rygaa

Rygaa commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator Author

edit: there can also be flickering during click and drag when the selection starts with hidden markdown formatting:

I fixed this issue
https://github.com/user-attachments/assets/f28d5cee-e697-41b0-be63-d5071d1e8e49

I noticed one minor issue with selections, where when the markup reveals on mouseup, the selection is sometimes missing the markdown formatting characters (even though the selection covered the entire word):

I created a different issue for it #15788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug It's a bug editor markdown-editor About the Markdown editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reveal markup on mouseup instead of mousedown

3 participants