Mobile: Disable auto correct, auto complete and auto capitalize for search fields - #14759
Conversation
📝 WalkthroughWalkthroughThe SearchBar component in the mobile app now sets three TextInput props to disable automatic input behaviour: Changes
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.Add a configuration file to your project to customize how CodeRabbit runs oxc. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/app-mobile/components/screens/SearchScreen/SearchBar.tsx`:
- Around line 54-55: The JSX string props autoCapitalize and autoComplete in
SearchBar.tsx use double quotes; update them to use single quotes to comply with
the repo style (change the attributes on the SearchBar / input element:
autoCapitalize and autoComplete to use single-quoted string literals).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3f868d9e-4ff4-452d-bdcc-1956c59be1b2
📒 Files selected for processing (1)
packages/app-mobile/components/screens/SearchScreen/SearchBar.tsx
According to https://discourse.joplinapp.org/t/ios-now-corrects-search-string/48684/3, in recent versions of Joplin mobile, the note search input uses auto correction / auto complete, which causes difficulty entering and submitting search terms when using a keyboard to navigate the app. Logically a search input should not use auto correct, auto complete or auto capitalize, as the input allows incomplete words or phrases by design, so should be excluded from those functions of the input method.
This PR disables auto correct, auto complete and auto capitalize for both the note search and tag search inputs in the app.
Testing
Behaviour before change:
search.auto.correct.before.mp4
Behaviour after change:
search.auto.correct.after.mp4