Skip to content

Mobile: Disable auto correct, auto complete and auto capitalize for search fields - #14759

Merged
laurent22 merged 2 commits into
laurent22:devfrom
mrjo118:search-disable-auto-correct
Mar 16, 2026
Merged

Mobile: Disable auto correct, auto complete and auto capitalize for search fields#14759
laurent22 merged 2 commits into
laurent22:devfrom
mrjo118:search-disable-auto-correct

Conversation

@mrjo118

@mrjo118 mrjo118 commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

According to https://discourse.joplinapp.org/t/ios-now-corrects-search-string/48684/3, in recent versions of Joplin mobile, the note search input uses auto correction / auto complete, which causes difficulty entering and submitting search terms when using a keyboard to navigate the app. Logically a search input should not use auto correct, auto complete or auto capitalize, as the input allows incomplete words or phrases by design, so should be excluded from those functions of the input method.

This PR disables auto correct, auto complete and auto capitalize for both the note search and tag search inputs in the app.

Testing

Behaviour before change:

search.auto.correct.before.mp4

Behaviour after change:

search.auto.correct.after.mp4

@coderabbitai

coderabbitai Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The SearchBar component in the mobile app now sets three TextInput props to disable automatic input behaviour: autoCapitalize="none", autoComplete="off", and autoCorrect={false}. No other logic or exported declarations were changed.

Changes

Cohort / File(s) Summary
SearchBar input configuration
packages/app-mobile/components/screens/SearchScreen/SearchBar.tsx
Added three TextInput props (autoCapitalize="none", autoComplete="off", autoCorrect={false}) to disable capitalization, autocomplete and autocorrection for the search input.

Suggested reviewers

  • Kaushalendra-Marcus

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Pr Description Must Follow Guidelines ❌ Error Testing section lacks explicit documentation of manual testing steps as required by GSoC guidelines, providing only screenshots without procedural details. Document specific manual testing steps performed, such as navigation actions, field interactions, and verification confirmations, to demonstrate reproducible verification alongside visual evidence.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: disabling auto correct, auto complete, and auto capitalization for search fields in the mobile app.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the rationale for disabling auto-correction, auto-completion, and auto-capitalization in search inputs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

@coderabbitai coderabbitai Bot added mobile All mobile platforms search labels Mar 16, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/app-mobile/components/screens/SearchScreen/SearchBar.tsx`:
- Around line 54-55: The JSX string props autoCapitalize and autoComplete in
SearchBar.tsx use double quotes; update them to use single quotes to comply with
the repo style (change the attributes on the SearchBar / input element:
autoCapitalize and autoComplete to use single-quoted string literals).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3f868d9e-4ff4-452d-bdcc-1956c59be1b2

📥 Commits

Reviewing files that changed from the base of the PR and between 65eb5e3 and 11ba809.

📒 Files selected for processing (1)
  • packages/app-mobile/components/screens/SearchScreen/SearchBar.tsx

Comment thread packages/app-mobile/components/screens/SearchScreen/SearchBar.tsx Outdated
@laurent22
laurent22 merged commit f9654a3 into laurent22:dev Mar 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mobile All mobile platforms search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants