[13.x] Add array maintenance mode driver for parallel testing#60489
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
ziadoz
changed the title
array maintenance mode driverarray maintenance mode driver for parallel testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple array-based maintenance mode driver, similar to existing cache and session drivers, that eases parallel testing.
If tests call
php artisan (up|down)in a parallel testsuite, the file-based driver inevitably trips up, and the cache-based one also gets tripped up byCachefacade mocking calls. However, with this new driver parallel testing works fine.Kinda niche I suppose, but our suppliers expect test coverage for deployment processes. Also, an array-based maintenance mode for tests in general seemed sensible to me.