Skip to content

[KEP-5440] Add documentation for mutable pod resources while job is suspended - #52800

Merged
k8s-ci-robot merged 1 commit into
kubernetes:dev-1.35from
kannon92:mutable-job
Nov 20, 2025
Merged

[KEP-5440] Add documentation for mutable pod resources while job is suspended#52800
k8s-ci-robot merged 1 commit into
kubernetes:dev-1.35from
kannon92:mutable-job

Conversation

@kannon92

@kannon92 kannon92 commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

Description

Add a section in Job documentation supporting KEP-5440.

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Oct 19, 2025
@netlify

netlify Bot commented Oct 19, 2025 •
edited
Loading

Copy link
Copy Markdown

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit b6bf8c4
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/691899adc544ee0008b21574

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 19, 2025
@k8s-ci-robot
k8s-ci-robot requested a review from mimowo October 19, 2025 20:34
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2025
@k8s-ci-robot
k8s-ci-robot requested a review from soltysh October 19, 2025 20:34
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2025
@kannon92 kannon92 mentioned this pull request Oct 19, 2025
Open
12 tasks
dipesh-rawat
dipesh-rawat reviewed Oct 19, 2025
View reviewed changes

@dipesh-rawat dipesh-rawat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kannon92 The Netlify build preview is failing because the PR currently doesn’t include the feature gate description file for the new MutablePodResourcesForSuspendedJobs feature gate. Please add a file named MutablePodResourcesForSuspendedJobs.md under: content/en/docs/reference/command-line-tools-reference/feature-gates/

For more details, please refer to the documentation here.

Refer (logs here)

9:35:30 PM: ERROR Invalid feature gate: 'MutablePodResourcesForSuspendedJobs' is not recognized or lacks a matching description file in 'en/docs/reference/command-line-tools-reference/feature-gates'

@dipesh-rawat

dipesh-rawat commented Oct 19, 2025

Copy link
Copy Markdown
Member

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Oct 19, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Oct 19, 2025
@dipesh-rawat

dipesh-rawat commented Oct 19, 2025

Copy link
Copy Markdown
Member

Hold until the upstream implementation k/k PR kubernetes/kubernetes#132441 is merged.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2025
@netlify

netlify Bot commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b6bf8c4
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/691899ad26ecb500083bb20c
😎 Deploy Preview https://deploy-preview-52800--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kannon92

kannon92 commented Oct 20, 2025

Copy link
Copy Markdown
Contributor Author

@kannon92 The Netlify build preview is failing because the PR currently doesn’t include the feature gate description file for the new MutablePodResourcesForSuspendedJobs feature gate. Please add a file named MutablePodResourcesForSuspendedJobs.md under: content/en/docs/reference/command-line-tools-reference/feature-gates/

For more details, please refer to the documentation here.

Refer (logs here)

9:35:30 PM: ERROR Invalid feature gate: 'MutablePodResourcesForSuspendedJobs' is not recognized or lacks a matching description file in 'en/docs/reference/command-line-tools-reference/feature-gates'

Ah thanks for that. Pushed up a fix for this.

lmktfy
lmktfy reviewed Oct 20, 2025
View reviewed changes

@lmktfy lmktfy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Here is some feedback.

Comment thread content/en/docs/concepts/workloads/controllers/job.md Outdated
Comment thread content/en/docs/concepts/workloads/controllers/job.md Outdated
Comment thread content/en/docs/concepts/workloads/controllers/job.md Outdated
Comment thread content/en/docs/concepts/workloads/controllers/job.md Outdated
Comment thread .../reference/command-line-tools-reference/feature-gates/MutablePodResourcesForSuspendedJobs.md Outdated
Comment thread .../reference/command-line-tools-reference/feature-gates/MutablePodResourcesForSuspendedJobs.md Outdated
@kannon92
kannon92 requested a review from lmktfy October 21, 2025 18:05
soltysh
soltysh approved these changes Oct 28, 2025
View reviewed changes

@soltysh soltysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from sig-apps pov, modulo one tiny suggestion

Comment thread content/en/docs/concepts/workloads/controllers/job.md Outdated
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2025
@k8s-ci-robot

k8s-ci-robot commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 8a120c6cda699e51c77006ace6831c3f4bfc18f6

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2025
@k8s-ci-robot
k8s-ci-robot requested a review from soltysh October 28, 2025 18:49
@kannon92

kannon92 commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

/hold cancel

Upstream PR has merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@kernel-kun

kernel-kun commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Hey folks 👋, this is Tushar Mittal (@kernel-kun) from v1.35 Release Docs team.

Regarding kubernetes/enhancements#5440
Please take a look at Documenting for a release - PR Ready for Review to get your Docs PR ready for review before Tuesday 18th November 2025.

Please let us know once this Docs PR is fully Ready for Review — meaning all documentation updates are complete and it’s awaiting reviewer feedback — so we can update our tracking.

Thank you!

@kannon92

kannon92 commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

This is ready for review.

tengqm
tengqm reviewed Nov 15, 2025
View reviewed changes
Comment thread content/en/docs/concepts/workloads/controllers/job.md Outdated
@kannon92
kannon92 requested a review from tengqm November 15, 2025 15:18
tengqm
tengqm reviewed Nov 15, 2025
View reviewed changes

@tengqm tengqm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2025
@k8s-ci-robot

k8s-ci-robot commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 9452aa29581ace5c9feb3ab496608db648f82754

@kannon92

kannon92 commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

I think this is just looking for an approved now.

dipesh-rawat
dipesh-rawat reviewed Nov 20, 2025
View reviewed changes

@dipesh-rawat dipesh-rawat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot

k8s-ci-robot commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@k8s-ci-robot
k8s-ci-robot merged commit e5b63bd into kubernetes:dev-1.35 Nov 20, 2025
6 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Apps Nov 20, 2025
dipesh-rawat
dipesh-rawat reviewed Dec 6, 2025
View reviewed changes

@dipesh-rawat dipesh-rawat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kannon92 Just noticed there is another feature gate MutableSchedulingDirectivesForSuspendedJobs as part of the KEP-5440 that is introduced in v1.35 through the upstream PR kubernetes/kubernetes#135104. It has not been added to the docs.

@kannon92

kannon92 commented Dec 7, 2025

Copy link
Copy Markdown
Contributor Author

@kannon92 Just noticed there is another feature gate MutableSchedulingDirectivesForSuspendedJobs as part of the KEP-5440 that is introduced in v1.35 through the upstream PR kubernetes/kubernetes#135104. It has not been added to the docs.

Oh good catch!

@mimowo could you help with that?

@mimowo

mimowo commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@kannon92 @dipesh-rawat I can update the docs with the feature gate. I will open the PR for review today if not too late.

@dipesh-rawat

dipesh-rawat commented Dec 8, 2025

Copy link
Copy Markdown
Member

@mimowo Yes, please go ahead and raise the PR. We still have time before the targeted release date next week.

@mimowo mimowo mentioned this pull request Dec 8, 2025
Merged
@mimowo

mimowo commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

I just opened: #53550, ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments
@dipesh-rawat dipesh-rawat dipesh-rawat left review comments
@mimowo mimowo Awaiting requested review from mimowo
@soltysh soltysh Awaiting requested review from soltysh
@lmktfy lmktfy Awaiting requested review from lmktfy

Assignees

@soltysh soltysh

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

1.35

Development

Successfully merging this pull request may close these issues.

8 participants

@kannon92 @dipesh-rawat @k8s-ci-robot @kernel-kun @mimowo @soltysh @tengqm @lmktfy