KEP-1880 - #46947
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/work-in-progress
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/sig network |
k8s-ci-robot
added
the
sig/network
|
Hello @aojea 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you! |
|
Hi @aojea, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@Princesso updated to reflect the feature gate state, the rest of functionality is already documented |
dipesh-rawat
left a comment
dipesh-rawat
left a comment
There was a problem hiding this comment.
@aojea We should also update the feature state in the reference page (here) to accurately reflect its in beta after promotion in v1.31.
Consider using the suggestion below when updating the feature state (here); it’s a data-driven method that will pull data from the feature gate description file, saving us the need for manual updates in the future.
- {{< feature-state for_k8s_version="v1.27" state="alpha" >}}
+ {{< feature-state feature_gate_name="MultiCIDRServiceAllocator" >}}Where to change: /docs/reference/networking/virtual-ips.md
Signed-off-by: Antonio Ojea <aojea@google.com>
|
changes applied @dipesh-rawat |
| fromVersion: "1.27" | ||
| toVersion: "1.30" | ||
| - stage: beta | ||
| defaultValue: false |
There was a problem hiding this comment.
This feature is promoted to Beta and its default remains "false"?
Why the promotion then?
There was a problem hiding this comment.
Since https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/3136-beta-apis-off-by-default the betas APIs are off by default, this present a challenge for new features that depend on new APIS.
It depends on each feature you can choose to be feature-gate and API beta both to be on or off by default, but not independently, in this case we apply https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/3136-beta-apis-off-by-default and we switch the API off , hence the feature has to be off or it will fail to run.
There was a problem hiding this comment.
Hello @aojea 👋! v1.31 Doc Lead here. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!
There was a problem hiding this comment.
this is just updating a feature gate, so no much technical to review
@danwinship @thockin can you PTAL and LGTM if you are ook with it?
There was a problem hiding this comment.
@aojea Thanks for the explanation. So the "root cause" is that beta APIs are not enabled by default, just as alpha APIs... sigh.
/approve
There was a problem hiding this comment.
nope, sorry, is not about enabling, is about being served byt the apiserver, alpha and beta APIs are not served by default , you need to enable them in the apiserver with the -runtime-config flag.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 7caa461ff99f74d20cb066ddadd8de5ea0b5e174 |
7 participants
KEP kubernetes/enhancements#1880
Moves to beta disabled by default in 1.31