Skip to content

KEP-4438: align alpha KEP with the merged implementation - #6218

Open
matthyx wants to merge 1 commit into
kubernetes:masterfrom
matthyx:restart
Open

KEP-4438: align alpha KEP with the merged implementation#6218
matthyx wants to merge 1 commit into
kubernetes:masterfrom
matthyx:restart

Conversation

@matthyx

@matthyx matthyx commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR-structure-exempt: targets kubernetes/enhancements, which uses the "KEP-: ..." title convention rather than conventional-commit

Summary

Aligns the KEP-4438 alpha document with the implementation merged in kubernetes/kubernetes#140133 — corrected alpha limitations, filled-in Design Details, updated test/monitoring references, and refreshed the Beta criteria.

Changes

  • Alpha limitations corrected — restarted sidecars now receive an ordered SIGTERM (not SIGKILL at sandbox teardown); the restart is not observable via pod status, so a kubelet_sidecar_restarts_during_termination_total metric is exposed instead; preStop runs once at t=0 on the instance that was live at the start of termination; added the no-backoff and ~1s-polling limitations.
  • Design Details filled in (was previously empty) with the implemented approach.
  • Test Plan unit- and e2e-test references updated to the tests that were added.
  • Monitoring documents the new metric.
  • Beta graduation criteria and Implementation History updated.

The feature-gate name in the code was renamed to match this KEP (SidecarsRestartableDuringPodTermination).

Opening as a draft for author/reviewer review.

Drafted with the help of AI.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matthyx
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jul 1, 2026
@kubernetes-prow kubernetes-prow Bot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 1, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 1, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: matthyx / name: Matthias Bertschy (6b1bdff)

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2026
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 1, 2026
@matthyx
matthyx marked this pull request as ready for review July 1, 2026 19:46
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from dchen1107 July 1, 2026 19:46
@matthyx
matthyx force-pushed the restart branch 2 times, most recently from d76b949 to 0b674b5 Compare July 12, 2026 20:51
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant