KEP-4438: align alpha KEP with the merged implementation - #6218
Open
matthyx wants to merge 1 commit into
Open
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: matthyx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
matthyx
marked this pull request as ready for review
July 1, 2026 19:46
4 tasks
matthyx
force-pushed
the
restart
branch
2 times, most recently
from
July 12, 2026 20:51
d76b949 to
0b674b5
Compare
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-structure-exempt: targets kubernetes/enhancements, which uses the "KEP-: ..." title convention rather than conventional-commit
Summary
Aligns the KEP-4438 alpha document with the implementation merged in kubernetes/kubernetes#140133 — corrected alpha limitations, filled-in Design Details, updated test/monitoring references, and refreshed the Beta criteria.
Changes
SIGTERM(not SIGKILL at sandbox teardown); the restart is not observable via pod status, so akubelet_sidecar_restarts_during_termination_totalmetric is exposed instead;preStopruns once at t=0 on the instance that was live at the start of termination; added the no-backoff and ~1s-polling limitations.The feature-gate name in the code was renamed to match this KEP (
SidecarsRestartableDuringPodTermination).Opening as a draft for author/reviewer review.
Drafted with the help of AI.