Skip to content

KEP-3973: update Consider Terminating Pods in Deployments - #5398

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
atiratree:pod-replacement-policy-1.34
Jun 11, 2025
Merged

KEP-3973: update Consider Terminating Pods in Deployments#5398
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
atiratree:pod-replacement-policy-1.34

Conversation

@atiratree

Copy link
Copy Markdown
Member
  • One-line PR description: update Consider Terminating Pods in Deployments KEP
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jun 11, 2025
@k8s-ci-robot
k8s-ci-robot requested review from kow3ns and soltysh June 11, 2025 06:22
@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Apps Jun 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2025
Comment on lines +658 to +659
DeploymentReplicaSetTerminatingReplicas feature should be enabled and graduated to beta first at least one release
before the DeploymentPodReplacementPolicy feature is.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighting this. It would be nice to have the DeploymentReplicaSetTerminatingReplicas graduated first (hopefully in 1.34), as it is a prerequisite for the DeploymentPodReplacementPolicy.

@atiratree

Copy link
Copy Markdown
Member Author

/assign @soltysh

@soltysh soltysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@k8s-ci-robot
k8s-ci-robot merged commit 11ce9e0 into kubernetes:master Jun 11, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 11, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in SIG Apps Jun 11, 2025
@atiratree atiratree mentioned this pull request Feb 3, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants