Skip to content

KEP-1287: Catch up KEP details to actual implementation - #3944

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
vinaykul:master
Jun 13, 2023
Merged

KEP-1287: Catch up KEP details to actual implementation#3944
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
vinaykul:master

Conversation

@vinaykul

@vinaykul vinaykul commented Apr 8, 2023

Copy link
Copy Markdown
Member
  • One-line PR description: Catch up the KEP description and details to what actually got implemented after various reviews and discussions.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Apr 8, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2023
@vinaykul

vinaykul commented Apr 8, 2023

Copy link
Copy Markdown
Member Author

/assign @dchen1107
/assign @derekwaynecarr
/cc @thockin

@bart0sh

bart0sh commented Apr 9, 2023

Copy link
Copy Markdown
Contributor

/assign @mrunalp @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2023
Comment thread go.mod

@thockin thockin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text changes LGTM, thanks

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 12, 2023
@mrunalp

mrunalp commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, vinaykul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@mrunalp

mrunalp commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot
k8s-ci-robot merged commit 87e3a35 into kubernetes:master Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

8 participants