Skip to content
This repository was archived by the owner on Jun 10, 2026. It is now read-only.

update classes applied to html math output#63

Merged
rowanc1 merged 2 commits into
jupyter-book:mainfrom
sglyon:update-math-html-classes
Jan 24, 2024
Merged

update classes applied to html math output#63
rowanc1 merged 2 commits into
jupyter-book:mainfrom
sglyon:update-math-html-classes

Conversation

@sglyon

@sglyon sglyon commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

@rowanc1 This goes along with jupyter-book/mystmd#862

@welcome

welcome Bot commented Jan 22, 2024

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@fwkoch fwkoch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hunting down these test cases. It is not very intuitive (nor nice to work with) that mystmd is dependent on these - certainly something to improve...

But for now, this is great, and we can just merge as soon as your other PR in mystmd is ready to go!

@rowanc1 rowanc1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sglyon - this is great and aligns this choice with the wider unified ecosystem. These were arbitrary choices that are now no longer arbitrary! Excited to see better integrations with the rehype/remark community as we make these sorts of changes.

@rowanc1 rowanc1 merged commit f07f9e9 into jupyter-book:main Jan 24, 2024
@welcome

welcome Bot commented Jan 24, 2024

Copy link
Copy Markdown

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@sglyon

sglyon commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Awesome thanks team!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants