Skip to content

fix: allow different images with same filename by deduplicating on co…#7563

Merged
urmauur merged 3 commits into
janhq:mainfrom
mykh-hailo:fix/chat-input-image-paste
Mar 5, 2026
Merged

fix: allow different images with same filename by deduplicating on co…#7563
urmauur merged 3 commits into
janhq:mainfrom
mykh-hailo:fix/chat-input-image-paste

Conversation

@mykh-hailo

@mykh-hailo mykh-hailo commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Describe Your Changes

  • Resolves the "Some images already attached" error when users attach different images that share the same filename.
  • Switched from filename-based to content-based deduplication. Image content is hashed with SHA-256; only identical content is treated as a duplicate. Different images with the same filename can now be attached.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@mykh-hailo mykh-hailo force-pushed the fix/chat-input-image-paste branch from 2a32b35 to 2837f8b Compare March 2, 2026 11:11
@mykh-hailo

Copy link
Copy Markdown
Contributor Author

Hi @louis-jan
Can you check this PR for #7516 please?

@louis-jan

Copy link
Copy Markdown
Contributor

Great, @mykh-hailo I will give a test and merge

@louis-jan louis-jan self-assigned this Mar 3, 2026
@louis-jan louis-jan self-requested a review March 3, 2026 03:44
@louis-jan louis-jan removed their assignment Mar 3, 2026
@louis-jan louis-jan requested a review from urmauur March 4, 2026 09:56
@urmauur

urmauur commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

LGTM

@urmauur urmauur merged commit 532f595 into janhq:main Mar 5, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this to QA in Jan Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA

Development

Successfully merging this pull request may close these issues.

bug: Unable to paste different images from clipboard "Some images already attached. image.png is already in the list"

3 participants