fix: gpt-oss disallows quantized cache types due to its use of attention sinks#7541
Merged
louis-jan merged 1 commit intoFeb 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents MLX inference from enabling quantized KV cache settings by default (to avoid failures with GPT-OSS models that use attention sinks), and improves streaming usage reporting by populating prompt/total token counts from MLX generation info.
Changes:
- Stop passing
kvBits,kvGroupSize, andquantizedKVStartintoGenerateParameters(disables default KV-cache quantization). - Populate
UsageInfo.prompt_tokensandUsageInfo.total_tokensfor streaming completions usinginfo.promptTokenCountandinfo.generationTokenCount.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
There will be a follow-up PR to enable quantized kvcache properly. |
urmauur
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
quantized attention does not support zero sinks.Fixes Issues
Self Checklist