Sync new change from Release/v0.7.7 to main#7518
Merged
Merged
Conversation
fix: temporary disable prompt cache
fix: broken assistant selection
fix: assistant for project does not work
Minh141120
approved these changes
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs changes from Release/v0.7.7 into main, affecting how thread assistants are represented in the web app and disabling prompt caching in the MLX server runtime.
Changes:
- Thread service now preserves
assistantsarrays (including model-only entries) instead of filtering out non-instruction assistants. - Chat UI assistant-selection logic was adjusted (including default selection behavior).
- MLX server prompt caching was commented out/disabled during generation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| web-app/src/services/threads/default.ts | Alters thread transformation and assistant/model payload handling when listing/creating threads. |
| web-app/src/services/tests/threads.test.ts | Updates expectations to match new assistant/model-only thread behavior. |
| web-app/src/routes/threads/$threadId.tsx | Changes system message derivation to always consider thread assistant (not gated by project). |
| web-app/src/containers/ChatInput.tsx | Updates assistant selection state initialization and dropdown selection logic. |
| mlx-server/Sources/MLXServer/ModelRunner.swift | Disables prompt-cache usage/clearing and runs generation without cache. |
Comments suppressed due to low confidence (1)
web-app/src/containers/ChatInput.tsx:1567
- The “None” highlighting logic relies on
!currentThread?.assistants?.length, but threads now appear to keep a model-only placeholder assistant (noinstructions) inthread.assistants. That makesassistants.length > 0even when there is no real assistant, so the UI can show no selection at all. Consider treating assistants withoutinstructionsas “none” here (or filtering them out at the service layer).
<DropdownMenuItem
className={!selectedAssistant && !currentThread?.assistants?.length ? 'bg-accent' : ''}
onClick={() => {
setSelectedAssistant(undefined)
if (currentThreadId) {
updateCurrentThreadAssistant(undefined as unknown as Assistant)
}
}}
>
<div className="flex items-center gap-2 w-full">
<span className="text-muted-foreground">—</span>
<span>None</span>
{!selectedAssistant && !currentThread?.assistants?.length && (
<span className="ml-auto text-xs text-muted-foreground">✓</span>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Vanalite
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist