Skip to content

refactor: hashing service - #21997

Merged
alextran1502 merged 25 commits into
mainfrom
fix/only-hash-local-tasks-ios
Sep 18, 2025
Merged

refactor: hashing service#21997
alextran1502 merged 25 commits into
mainfrom
fix/only-hash-local-tasks-ios

Conversation

@shenlong-tanwen

@shenlong-tanwen shenlong-tanwen commented Sep 15, 2025

Copy link
Copy Markdown
Member

Description

  • Hashing is now concurrent on both iOS and the Android implementation
  • The iOS implementation does not create a new temporary file for hashing but uses a streaming implementation
  • Reduced the number of data transfer between the platform side and the flutter side as we now send only the assetIds to the platform side which fetches the file, hashes, base64 encodes them and shares back the result
  • Hashes all the local assets on iOS. For assets not available on the device, it only downloads assets from iCloud from albums that have been selected for backups.

@shenlong-tanwen shenlong-tanwen changed the title download only backup selected assets refactor: hashing service Sep 15, 2025
mertalev
mertalev reviewed Sep 16, 2025
View reviewed changes
Comment thread mobile/ios/Runner/Sync/MessagesImpl.swift Outdated
Comment thread mobile/lib/domain/services/hash.service.dart
Comment thread mobile/android/app/src/main/kotlin/app/alextran/immich/sync/MessagesImplBase.kt Outdated
Comment thread mobile/lib/constants/constants.dart Outdated
@mertalev
mertalev force-pushed the fix/only-hash-local-tasks-ios branch from 0285d54 to dc790d1 Compare September 17, 2025 01:42
@mertalev
mertalev force-pushed the fix/only-hash-local-tasks-ios branch from dc790d1 to 53f10b8 Compare September 17, 2025 14:59
@alextran1502
alextran1502 merged commit 532ec10 into main Sep 18, 2025
48 checks passed
@alextran1502
alextran1502 deleted the fix/only-hash-local-tasks-ios branch September 18, 2025 04:42
@shenlong-tanwen shenlong-tanwen mentioned this pull request Sep 25, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mertalev mertalev mertalev approved these changes
@alextran1502 alextran1502 Awaiting requested review from alextran1502

Assignees

No one assigned

Labels

changelog:enhancement 📱mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shenlong-tanwen @mertalev @alextran1502