fix(details): add shift+p binding for preview_toggle_bottom#649
Merged
Conversation
The revisions, revisions.evolog, and oplog scopes all bind shift+p to ui.preview_toggle_bottom, but revisions.details was missing it. Add the binding so the preview position toggle is available consistently in all scopes where p toggles the preview.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
May 7, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [idursun/jjui](https://github.com/idursun/jjui) | patch | `v0.10.3` → `v0.10.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>idursun/jjui (idursun/jjui)</summary> ### [`v0.10.4`](https://github.com/idursun/jjui/releases/tag/v0.10.4) [Compare Source](idursun/jjui@v0.10.3...v0.10.4) A quick maintenance release with a few improvements and fixes. #### Features ##### Absorb operation Absorb is now an operation, similar to rebase, revert, duplicate, and other revision operations, instead of immediately running `jj absorb` with jj's default destination set. Default absorb targets are preselected and shown with `<< into >>`. Use `space` to toggle candidate targets, `enter` to apply, and `esc` to cancel. Leaving the target set unchanged keeps the previous plain absorb behaviour; changing the set constrains absorb to the selected targets. ([#​634](idursun/jjui#634), [#​640](idursun/jjui#640)) ##### Directory entries in fuzzy file search Fuzzy file/path search now includes directory entries such as `src/` and `src/pkg/`, not only leaf file paths. This makes it easier to filter or jump by directory in larger trees. ([#​642](idursun/jjui#642)) #### Improvements ##### Better theme control for selected rows Selected-row styling is now theme-owned for revset completion, target picker, details lists, and menu shortcuts. Themes can customise selected sub-roles such as `"revset completion selected matched"`, `"revset completion selected text"`, `"revset completion selected dimmed"`, `"picker selected matched"`, and `"picker selected text"`. This fixes cases where `"revset completion selected"` changed the selected row background but not the selected foreground or bold styling. Default selected backgrounds for revset completion and target picker now also align with revision details. ([#​637](idursun/jjui#637)) ##### Consistent preview position toggle in details `shift+p` now toggles the preview between side and bottom positions in the details view, matching the existing behaviour in revisions, evolog, and oplog views. ([#​649](idursun/jjui#649)) #### Fixes ##### Lua revset actions outside the revset editor Lua scripts can now dispatch revset actions such as `revset.set(...)` even when the revset editor is not open. This fixes custom revision-scoped Lua actions that update the current revset. ##### Stale file selection after closing details Closing the details view now clears stale selected-file state, and restoring an existing details operation resynchronises file selection. This fixes cases where a later command error could make `Esc` behave incorrectly instead of dismissing the visible flash message. ([#​643](idursun/jjui#643)) ##### Bookmark names with special characters Bookmark operations now match bookmark names exactly. This fixes deleting bookmarks whose names contain characters that jj would otherwise interpret as string pattern syntax, such as `1.3.63-+-json-length-fix`. ([#​632](idursun/jjui#632), [#​650](idursun/jjui#650)) #### What's Changed - feat(absorb): add target picker for jj absorb --into by [@​manusajith](https://github.com/manusajith) in [#​640](idursun/jjui#640) - feat: include directories in path entries for fuzzy\_files by [@​baggiiiie](https://github.com/baggiiiie) in [#​642](idursun/jjui#642) - Remove unused struct fields, methods, and functions by [@​nikosavola](https://github.com/nikosavola) in [#​648](idursun/jjui#648) - fix(details): add shift+p binding for preview\_toggle\_bottom by [@​ansel1](https://github.com/ansel1) in [#​649](idursun/jjui#649) - fix(ui): unable to dismiss flash message after split command error by [@​baggiiiie](https://github.com/baggiiiie) in [#​643](idursun/jjui#643) - fix(bookmarks): match bookmark names exactly by [@​baggiiiie](https://github.com/baggiiiie) in [#​650](idursun/jjui#650) #### New Contributors - [@​manusajith](https://github.com/manusajith) made their first contribution in [#​640](idursun/jjui#640) - [@​nikosavola](https://github.com/nikosavola) made their first contribution in [#​648](idursun/jjui#648) - [@​ansel1](https://github.com/ansel1) made their first contribution in [#​649](idursun/jjui#649) **Full Changelog**: <idursun/jjui@v0.10.3...v0.10.4> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNjguNSIsInVwZGF0ZWRJblZlciI6IjQzLjE2OC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
revisions,revisions.evolog, andoplogscopes all bindshift+ptoui.preview_toggle_bottom(move preview between side and bottom position), but therevisions.detailsscope only hasp→ui.preview_toggleand is missing the correspondingshift+pbinding.This means that once a user enters the details view (pressing
lon a revision), they lose the ability to toggle the preview position until they go back to the revisions view — even thoughpstill toggles the preview on/off in details mode.Change
Add the missing binding in
internal/config/default/bindings.toml:The action
ui.preview_toggle_bottomis an existing built-in — no code changes required, and the action catalog does not need to be regenerated.Verification
go build ./cmd/jjui— OKgo test ./...— all packages passshift+pnow toggles preview between side and bottom positions, matching the behavior inrevisions,revisions.evolog, andoplog.