Skip to content

Cannot override certain built-in actions #586

@shyun3

Description

@shyun3

Description

I'm trying to override the revisions.details.diff and revisions.evolog.diff built-in actions based on the example in the docs, but it doesn't seem to be working. I looked up the action names from internal/config/default/bindings.toml.

It's possible other built-in actions may be affected as well.

Steps to Reproduce the Problem

  1. Use the following config.lua:
    function setup(config)
      config.action("revisions.details.diff", function() error("details diff") end)
      config.action("revisions.evolog.diff", function() error("evolog diff") end)
    end
  2. Launch jjui and go to a non-empty commit
  3. Press l to go to the details view and press d to diff
  4. Exit the details view and press v to enter the evolog, then press d to diff

Expected Behavior

An error occurs on each diff command.

Actual Behavior

No errors occur.

Specifications

  • Platform: WSL Ubuntu 24.04.3
  • Version: 0.10.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions