Theme rendering problem in 0.9.11

[kuznetsss]

Hi, thanks for the amazing software!

It seems there is something changed in theme rendering in the version 0.9.11 comparing to0.9.10.
Here is how everforest theme looked at 0.9.10:

And in 0.9.11 with the same config:

My config:

~/.config/jjui/config.toml

      [keys]
      force_apply = ["ctrl+enter"]

      [ui]
      theme = "everforest"

~/.config/jjui/themes/everforest.toml

## tinted-jjui (https://github.com/vic/tinted-jjui)
# Scheme name: Everforest
# Scheme author: Sainnhe Park (https://github.com/sainnhe)
# Template author: Victor Borja <vborja@apache.org> (https://github.com/vic)



"text"      = { fg = "#d3c6aa", bg = "#2d353b" }
"dimmed"    = { fg = "#859289", bg = "#2d353b" }
"title"     = { fg = "#7fbbb3", bold = true }
"shortcut"  = { fg = "#d699b6" }
"matched"   = { fg = "#dbbc7f" }
"border"    = { fg = "#859289" }
"selected"  = { bg = "#343f44", fg = "#d3c6aa", bold = true }

"source_marker" = { bg = "#83c092", fg = "#2d353b", bold = true }
"target_marker" = { bg = "#a7c080", fg = "#2d353b", bold = true }

"status" = { bg = "#343f44" }
"status title" = { fg = "#2d353b", bg = "#7fbbb3", bold = true }

"revset title" = { fg = "#7fbbb3", bold = true }
"revset text" = { fg = "#d3c6aa", bold = true }
"revset completion text" = { fg = "#d3c6aa" }
"revset completion matched" = { fg = "#dbbc7f", bold = true }
"revset completion dimmed" = { fg = "#859289" }
"revset completion selected" = { bg = "#475258", fg = "#d3c6aa" }

"revisions" = { fg = "#d3c6aa" }
"revisions selected" = { bg = "#343f44"}
"revisions dimmed" = { fg = "#859289" }
"revisions details selected" = { bg = "#475258" }
"oplog selected" = { bold = true }

"evolog" = { fg = "#d3c6aa" }
"evolog selected" = { bg = "#475258", fg = "#d3c6aa", bold = true }

"menu" = { bg = "#2d353b" }
"menu title" = { fg = "#2d353b", bg = "#d699b6", bold = true }
"menu shortcut" = { fg = "#d699b6" }
"menu matched" = { fg = "#dbbc7f", bold = true }
"menu dimmed" = { fg = "#859289" }
"menu border" = { fg = "#343f44" }
"menu selected" = { bg = "#475258", fg = "#d3c6aa" }

"help" = { bg = "#2d353b" }
"help title" = { fg = "#a7c080", bold = true, underline = true }
"help border" = { fg = "#343f44" }

"preview" = { fg = "#d3c6aa" }
"preview border" = { fg = "#343f44" }

"confirmation" = { bg = "#2d353b" }
"confirmation text" = { fg = "#7fbbb3", bold = true }
"confirmation dimmed" = { fg = "#859289" }
"confirmation border" = { fg = "#e67e80", bold = true }
"confirmation selected" = { bg = "#475258", fg = "#d3c6aa" }

"undo" = { bg = "#2d353b" }
"undo confirmation dimmed" = { fg = "#859289" }
"undo confirmation selected" = { bg = "#475258", fg = "#d3c6aa" }

"success" = { fg = "#a7c080", bold = true }
"error" = { fg = "#e67e80", bold = true }
"revisions rebase source_marker" = { bold = true }
"revisions rebase target_marker" = { bold = true }
"status shortcut" = { fg = "#d699b6" }
"status dimmed" = { fg = "#859289" }

"details" = { fg = "#d3c6aa" }
"details selected" = { bold = true }
"completion" = { fg = "#d3c6aa" }
"completion selected" = { bold = true }
"rebase" = { bold = true }

"workspace" = { fg = "#7fbbb3" }
"branch" = { fg = "#e69875" }
"commit" = { fg = "#a7c080" }
"file" = { fg = "#dbbc7f" }
"change" = { fg = "#e67e80" }
"bookmark" = { fg = "#d699b6" }

Could you please help me to understand whether it is a bug or something in my config should be updated?

[idursun]

Hey, thanks for the report!

It should be fixed in 83468d0 now. The issue was the new rendering system renders only to the screen when there's content to render which skipped over the gaps between menu items, hence leaving them blank.

Current fix is bringing back the background colour but I will have to do another pass over the theme system at some point.

[kuznetsss]

Thanks for the quick fix!
Now menu is rendered correctly, but the background of the revisions list is the same as on my screenshot for 0.9.11. Background color is only applied to the areas with some text, not to the whole line.
But it is not a problem for me because I removed the entries you mentioned in the other comment.

[idursun]

By the way, I think your theme would look better if you remove the following entries from it as they are overriding the jj colours for modified, deleted, added items in details view and also overriding the revisions fg colour.

"text"      = { fg = "#d3c6aa", bg = "#2d353b" }
"revisions" = { fg = "#d3c6aa" }
"details" = { fg = "#d3c6aa" }