Prevent pull-to-refresh from triggering while scrolling in a nested scrollable element on the page#310
Merged
Merged
Conversation
…crollable element on the page
|
Works like a charm, thanks @jayohms! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes: #294
This prevents pull-to-refresh from being triggered when (potentially) nested scrolling within an element on the page that is using
overflow-y: scrolloroverflow-y: auto. To address this, the following item were added:TurboWebViewthat the currently touched element is scrollable.TurboWebView.TurboSwipeRefreshLayoutchecks to see if its scrollable child can scroll up, check the state of theTurboWebViewif a scrollable element is currently being touched.