Skip to content

feat: make log writer configurable#283

Merged
nrwiersma merged 1 commit into
hamba:mainfrom
antiphp:stdout
Mar 10, 2025
Merged

feat: make log writer configurable#283
nrwiersma merged 1 commit into
hamba:mainfrom
antiphp:stdout

Conversation

@antiphp

@antiphp antiphp commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

Goal of this PR

Keep using os.Stdout for the logger, but make os.Stderr a configurable option.

How did I test it?

replace directive in go.mod of a project that uses hamba/cmd.

@nrwiersma nrwiersma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrwiersma nrwiersma merged commit a606098 into hamba:main Mar 10, 2025
@antiphp antiphp deleted the stdout branch March 10, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants