feat: Support Groovy 6 changes to GroovyDoc (closes #381) - #382
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends GMavenPlus GroovyDoc generation to support newer Groovy (Groovy 6+) behavior by adding new GroovyDoc options (e.g., syntax highlighter/theme, additional stylesheets) and introducing a preLanguage configuration that triggers Groovy’s PreLanguageRewriter post-processing.
Changes:
- Add new GroovyDoc Mojo parameters and wire them into GroovyDoc properties, plus copy support for additional stylesheets.
- Add
preLanguagetoGroovyDocConfigurationand propagate it from the Mojo into GroovyDoc generation. - Add/extend unit tests around property setup, preLanguage propagation, and additional stylesheet handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/test/java/org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojoTest.java | Adds tests for new GroovyDoc properties, preLanguage propagation, and additional stylesheet copying. |
| src/main/java/org/codehaus/gmavenplus/util/GroovyCompiler.java | Invokes Groovy 6 PreLanguageRewriter after GroovyDoc generation when configured. |
| src/main/java/org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojo.java | Adds new GroovyDoc parameters, includes them in doc properties, copies additional stylesheets, and passes preLanguage into configuration. |
| src/main/java/org/codehaus/gmavenplus/model/GroovyDocConfiguration.java | Adds a preLanguage field with getter/setter for forked/in-process GroovyDoc generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
keeganwitt
marked this pull request as ready for review
May 14, 2026 03:59
…er Groovy versions
…ties when running on older Groovy versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.