Skip to content

feat: Support Groovy 6 changes to GroovyDoc (closes #381) - #382

Merged
keeganwitt merged 3 commits into
masterfrom
381
May 27, 2026
Merged

feat: Support Groovy 6 changes to GroovyDoc (closes #381)#382
keeganwitt merged 3 commits into
masterfrom
381

Conversation

@keeganwitt

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends GMavenPlus GroovyDoc generation to support newer Groovy (Groovy 6+) behavior by adding new GroovyDoc options (e.g., syntax highlighter/theme, additional stylesheets) and introducing a preLanguage configuration that triggers Groovy’s PreLanguageRewriter post-processing.

Changes:

  • Add new GroovyDoc Mojo parameters and wire them into GroovyDoc properties, plus copy support for additional stylesheets.
  • Add preLanguage to GroovyDocConfiguration and propagate it from the Mojo into GroovyDoc generation.
  • Add/extend unit tests around property setup, preLanguage propagation, and additional stylesheet handling.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/test/java/org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojoTest.java Adds tests for new GroovyDoc properties, preLanguage propagation, and additional stylesheet copying.
src/main/java/org/codehaus/gmavenplus/util/GroovyCompiler.java Invokes Groovy 6 PreLanguageRewriter after GroovyDoc generation when configured.
src/main/java/org/codehaus/gmavenplus/mojo/AbstractGroovyDocMojo.java Adds new GroovyDoc parameters, includes them in doc properties, copies additional stylesheets, and passes preLanguage into configuration.
src/main/java/org/codehaus/gmavenplus/model/GroovyDocConfiguration.java Adds a preLanguage field with getter/setter for forked/in-process GroovyDoc generation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/org/codehaus/gmavenplus/util/GroovyCompiler.java Outdated
Comment thread src/main/java/org/codehaus/gmavenplus/util/GroovyCompiler.java Outdated
@keeganwitt
keeganwitt marked this pull request as ready for review May 14, 2026 03:59
@keeganwitt
keeganwitt merged commit 1a93e6a into master May 27, 2026
5 checks passed
@keeganwitt
keeganwitt deleted the 381 branch May 27, 2026 04:33
@keeganwitt keeganwitt added this to the 5.0.0 milestone May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants