Fix Gradle nativeTest test resource detection#929
Draft
jormundur00 wants to merge 1 commit into
Draft
Conversation
b3a2787 to
985955a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #537
Spec Fit
Issue 537 reports that Gradle
nativeTestomits resources fromsrc/test/resources, even though ordinary JVMtestsees them. Existing native-test specs already require the Gradle test binary to derive classes, resources, classpath, test identifiers, and JUnit support from the Gradletestsource set/task, so no spec change was needed.Relevant behavior is covered by
gradle/FS-gradle-native-tests.1,gradle/FS-gradle-native-image-tasks.1, androot/FS-native-tests.2.Implementation Summary
junit-platform-unique-ids.*discovery-list files from detected test resources.src/test/resources/db/mysql_conf_override, runsnativeTestwithout explicit resource configuration, and verifies the native test executable can load the resource.nativeTestresource fix.Validation Evidence
Passed locally:
JAVA_HOME=/home/jovan/.sdkman/candidates/java/17.0.12-graal GRAALVM_HOME=/home/jovan/.sdkman/candidates/java/21.0.11-graal ./gradlew :native-gradle-plugin:functionalTest --tests "org.graalvm.buildtools.gradle.JavaApplicationWithResourcesFunctionalTest.native tests include test resources without explicit resource configuration"JAVA_HOME=/home/jovan/.sdkman/candidates/java/17.0.12-graal GRAALVM_HOME=/home/jovan/.sdkman/candidates/java/17.0.12-graal ./gradlew :native-gradle-plugin:inspectionsgit diff --checkNot completed locally:
grund checkis currently blocked before patch-specific citation validation by repository-wide stale grund init blocks in AGENTS files../gradlew build, and the full:native-gradle-plugin:functionalTestsuite were not run locally.Review Readiness
Draft PR. Agent review found no requirements, spec/grounding, implementation, or validation blockers. Remaining validation gaps are documented above.
Remaining Human Follow-up