Fix Maven metadata repository fallback mutation#914
Draft
jormundur00 wants to merge 1 commit into
Draft
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #913.
Spec-fit summary
This keeps Maven reachability metadata repository resolution aligned with the existing Maven metadata repository behavior: fallback URLs are used for downloading metadata without mutating the Maven metadata repository configuration object. Explicit
localPath,url, andversionconfiguration behavior remains covered by the existing metadata functional tests.Implementation summary
metadataRepositoryConfiguration.setUrl(targetUrl)fallback mutations inAbstractNativeMojo.Validation evidence
Passed locally:
git diff --checkgrund checkgrund fmt . --marker --checkJAVA_HOME=/home/jovan/.sdkman/candidates/java/17.0.12-graal PATH=/home/jovan/.sdkman/candidates/java/17.0.12-graal/bin:$PATH ./gradlew :native-maven-plugin:test --tests org.graalvm.buildtools.maven.AbstractNativeMojoTestJAVA_HOME=/home/jovan/.sdkman/candidates/java/17.0.12-graal GRAALVM_HOME=/home/jovan/.sdkman/candidates/java/21.0.11-graal PATH=/home/jovan/.sdkman/candidates/java/17.0.12-graal/bin:$PATH ./gradlew :native-maven-plugin:functionalTest --tests "org.graalvm.buildtools.maven.*Metadata*"JAVA_HOME=/home/jovan/.sdkman/candidates/java/17.0.12-graal PATH=/home/jovan/.sdkman/candidates/java/17.0.12-graal/bin:$PATH ./gradlew :native-maven-plugin:inspectionsReview readiness
Draft PR. The latest local review found no blocking findings and marked the change ready to publish.
Remaining human follow-up
Full repository CI and the full
:native-maven-plugin:functionalTestmatrix were not run locally; rely on repository CI or run those broader checks before merge.