Skip to content

fix(spanner): avoid evaluation-order issue in function arguments#9452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devbww merged 1 commit into from
Jul 12, 2022
Merged

fix(spanner): avoid evaluation-order issue in function arguments #9452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions google/cloud/spanner/internal/connection_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,10 @@ spanner::RowStream ConnectionImpl::ReadImpl(
tracing_options](std::string const& resume_token) mutable {
if (!resume_token.empty()) request->set_resume_token(resume_token);
auto context = absl::make_unique<grpc::ClientContext>();
auto grpc_reader = stub->StreamingRead(*context, *request);
std::unique_ptr<PartialResultSetReader> reader =
absl::make_unique<DefaultPartialResultSetReader>(
std::move(context), stub->StreamingRead(*context, *request));
std::move(context), std::move(grpc_reader));
if (tracing_enabled) {
reader = absl::make_unique<LoggingResultSetReader>(std::move(reader),
tracing_options);
Expand Down Expand Up @@ -688,9 +689,10 @@ ResultType ConnectionImpl::CommonQueryImpl(
tracing_options](std::string const& resume_token) mutable {
if (!resume_token.empty()) request.set_resume_token(resume_token);
auto context = absl::make_unique<grpc::ClientContext>();
auto grpc_reader = stub->ExecuteStreamingSql(*context, request);
std::unique_ptr<PartialResultSetReader> reader =
absl::make_unique<DefaultPartialResultSetReader>(
std::move(context), stub->ExecuteStreamingSql(*context, request));
std::move(context), std::move(grpc_reader));
if (tracing_enabled) {
reader = absl::make_unique<LoggingResultSetReader>(std::move(reader),
tracing_options);
Expand Down