Update domain function to return all scaled-positions rather than only [min, max]#380
Conversation
gka
left a comment
There was a problem hiding this comment.
I think we should also adjust the test in test/scales.test.js for a multi-stop domain. And it make sense to update the documentation in docs/readme.md.
|
Thanks for the feedback, just resolved both comments! |
|
ah dang, just saw that the tests don't pass 😅. you didn't run them locally did you? going to submit another PR to address this. |
|
oh sorry about that, nope I did not run them I should have specified that. Will try to run them and fix |
|
I'll make sure tests are run on Github so this don't happen again :) see #381 |
|
Alright, it now seems easier to maintain how you differentiate |
See #376 (comment)