ref(options): Group Godot logger options under options.godot_logger#759
Open
limbonaut wants to merge 12 commits into
Open
ref(options): Group Godot logger options under options.godot_logger#759limbonaut wants to merge 12 commits into
options.godot_logger#759limbonaut wants to merge 12 commits into
Conversation
limbonaut
force-pushed
the
ref/app-hang-renames
branch
from
8dce517 to
7df1919
Compare
limbonaut
force-pushed
the
ref/godot-logger-renames
branch
from
2dd8a9f to
087f3b5
Compare
limbonaut
force-pushed
the
ref/godot-logger-renames
branch
from
087f3b5 to
77596f8
Compare
JoshuaMoelans
approved these changes
Jun 16, 2026
JoshuaMoelans
left a comment
JoshuaMoelans
left a comment
Member
There was a problem hiding this comment.
LGTM, just two small fixes
- in https://github.com/getsentry/sentry-godot/blob/ref/godot-logger-renames/src/sentry/godot_error_types.h#L31 it still references
logger_event_mask; should begodot_logger.event_mask
|
|
||
| void SentryOptions::set_logger_messages_as_breadcrumbs(bool p_enabled) { | ||
| void SentryOptions::deprecated_set_logger_messages_as_breadcrumbs(bool p_enabled) { | ||
| WARN_DEPRECATED_MSG("The \"logger_messages_as_breadcrumbs\" option is deprecated. Set the MASK_MESSAGE flag in \"logger_breadcrumb_mask\" instead."); |
Member
There was a problem hiding this comment.
logger_breadcrumb_mask is also deprecated
Suggested change
| WARN_DEPRECATED_MSG("The \"logger_messages_as_breadcrumbs\" option is deprecated. Set the MASK_MESSAGE flag in \"logger_breadcrumb_mask\" instead."); | |
| WARN_DEPRECATED_MSG("The \"logger_messages_as_breadcrumbs\" option is deprecated. Set the MASK_MESSAGE flag in \"godot_logger.breadcrumb_mask\" instead."); |
Collaborator
Author
There was a problem hiding this comment.
Nice catch, thanks!
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR groups the flat
logger_*options into a newgodot_loggeroptions object onSentryOptions. These options configure the SDK's integration with Godot's logging system, which captures engine errors, script errors, and printed messages as Sentry events, breadcrumbs, and logs. The new structure follows how other Sentry SDKs group feature-specific options (for example, theLogsandMetricsoption groups in sentry-java), shortens the option names, and removes the ambiguity between this integration andSentrySDK.logger, Sentry's structured-logging API.options.godot_logger#758For reviewers
logger_*properties remain as deprecated aliases that proxy to the new object and warn on use, following the same pattern as the earlier app hang renames. Removal is scheduled with the other deprecations (January 2027 or version 3.0).include_sourcebecameinclude_source_context(matches the Python SDK option), andGodotLoggerEventMaskwith itsMASK_*constants intentionally stays onSentryOptions(namespace level in C#) so that future options outside the logger group can reference it.sentry/godot_logger/*, with a schema v3 migration that renames persisted settings automatically; the demo project's settings are migrated as part of this PR.[Obsolete]shims, since it has never been released as stable.