Fix vertical flipping c720 fields with processed met#529
Merged
yantosca merged 2 commits intoDec 11, 2025
Merged
Conversation
lizziel
added
topic: Input Data
lizziel
added
the
no-diff-to-benchmark
Contributor
Author
|
This PR is done but has not yet been tested. |
lizziel
force-pushed
the
bugfix/fix_vertical_flipping_C720_fields_with_processed_met
branch
from
9e46d1b to
532149f
Compare
…issue This update requires a submodule update for GEOS-Chem. The issue only affected usage of GEOS-FP C720 files (top-down) with processed met fields (bottom-up). Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
…s flux Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
bugfix/fix_vertical_flipping_C720_fields_with_processed_met
branch
from
532149f to
d589c42
Compare
yantosca
added a commit
to geoschem/geos-chem
that referenced
this pull request
Dec 11, 2025
This merge brings PR #3131 (Fix vertical flipping of C720 met fields when using with GEOS-FP processed lat-lon data, by @lizziel) into the GEOS-Chem 14.7.0 development stream. PR #3131 is the companion PR to geoschem/GCHP#529. These PRs fix a bug by splitting the single category for vertical direction of imports into 4 categories (mass flux, wind, humidity, and everything else), which is needed for GCHP C720. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added a commit
to geoschem/GCClassic
that referenced
this pull request
Dec 11, 2025
This commit informs the GCClassic superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: a3a795878 Merge PR #3131 (Fix vertical flipping of GEOS-FP C720 met fields) PR #3131 is the companion PR to geoschem/GCHP#529. These PRs fix a bug by splitting the single category for vertical direction of imports into 4 categories (mass flux, wind, humidity, and everything else), which is needed for GCHP C720. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added a commit
that referenced
this pull request
Dec 11, 2025
This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: a3a795878 Merge PR #3131 (Fix vertical flipping of GEOS-FP C720 met fields) PR #3131 is the companion PR to #529. These PRs fix a bug by splitting the single category for vertical direction of imports into 4 categories (mass flux, wind, humidity, and everything else), which is needed for GCHP C720. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
deleted the
bugfix/fix_vertical_flipping_C720_fields_with_processed_met
branch
Contributor
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : 33d6725 GEOS-Chem update: Merge PR #3131 (Fix vertical flipping for C720)
GEOS-Chem : a3a795878 Merge PR #3131 (Fix vertical flipping of GEOS-FP C720 met fields)
HEMCO : 43ad195 Merge PR #346 (Replace gcc 12 w/ gcc 15 in Mac GitHub Action )
Cloud-J : 1dff6fe Merge pull request #31 from geoschem/release/8.0.2
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 38
Submitted as SLURM job: 50500422
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All GEOS-Chem Classic tests were zero-diff w/r/t
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : fb61897 Merge PR #529 (Fix vertical flipping c720 fields with processed met)
MAPL : d1d528e5 Merge pull request #39 from geoschem/feature/mapl_2.55.0
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : bd401dc Merge pull request #8 from yuanjianz/gchp/main
FMS : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : 348620f Merge PR #11 (Scale tracers by pressure ratio in first timestep)
geos-chem : a3a795878 Merge PR #3131 (Fix vertical flipping of GEOS-FP C720 met fields)
HEMCO : 43ad195 Merge PR #346 (Replace gcc 12 w/ gcc 15 in Mac GitHub Action )
Cloud-J : 1dff6fe Merge pull request #31 from geoschem/release/8.0.2
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
GFE : bac529f Merge pull request #40 from Goddard-Fortran-Ecosystem/feature/mathomp4/update-gftl-1.15.2
Number of execution tests: 12
Submitted as SLURM job: 50500140
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All GCHP tests were zero-diff w/r/t |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR incorporates new entries in GCHP config file GCHP.rc that are brought in with a companion PR in the GEOS-Chem repository (geoschem/geos-chem#3131). This fixes a problem vertically flipping met-fields when using GEOS-FP C720 files (top-down) with GEOS-FP processed 0.25x0.625 files (bottom-up).
Expected changes
This update does not impact benchmarking. It is zero diff except for the specific case of using GEOS-FP C720 files with GEOS-FP processed fields.
Reference(s)
None
Related Github Issue
#527
Companion PR required: geoschem/geos-chem#3131