fix(app): pad no-connection banner below status bar#85
Merged
Conversation
The offline banner overlapped the status bar under edge-to-edge. Apply status bar inset padding to the banner text (background still extends behind the status bar) and consume that inset for the NavHost while the banner is visible, so Scaffolded screens don't double-pad.
Contributor
Android debug APKArtifact:
|
garfiec
added a commit
that referenced
this pull request
May 13, 2026
Replace the `consumeWindowInsets(if (!isConnected) X else WindowInsets(0,0,0,0))` form (shipped in #85) with the idiomatic `Modifier.then(if (!isConnected) … else Modifier)` conditional. The two are functionally equivalent — consuming a zero inset is a no-op — but `.then` is the standard Compose pattern for conditional modifier application. Follow-up to #85.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The offline banner drew underneath the transparent status bar under edge-to-edge,
so the text overlapped the system clock/icons. Pad the banner content below the
status bar inset while letting the red background still extend behind it, and
consume the status bar inset for the NavHost while the banner is visible so
Scaffolded screens below don't double-pad.
Before / After