Skip to content

setup.hpp: Moved code in meaningful order. - #392

Closed
Tirus42 wants to merge 1 commit into
g-truc:masterfrom
Tirus42:master
Closed

setup.hpp: Moved code in meaningful order.#392
Tirus42 wants to merge 1 commit into
g-truc:masterfrom
Tirus42:master

Conversation

@Tirus42

@Tirus42 Tirus42 commented Aug 28, 2015

Copy link
Copy Markdown

Fixed code order of define check.

@Groovounet

Copy link
Copy Markdown
Member

Sorry I don't get the benefit of this pull request.

Thanks,
Christophe

@Groovounet Groovounet closed this Aug 31, 2015
@Tirus42

Tirus42 commented Sep 2, 2015

Copy link
Copy Markdown
Author

It fixes an error in your
#if GLM_ARCH == GLM_ARCH_PURE
because GLM_ARCH and GLM_ARCH_PURE is defined later.

(See line 727 and 736)

Found with gcc -Werror=undef

@Groovounet

Copy link
Copy Markdown
Member

This issue has been fixed in master branch for GLM 0.9.7.1 release.

Thanks for reporting,
Christophe

@Groovounet Groovounet closed this Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants