Consistent spec titles#609
Merged
milancurcic merged 2 commits intoDec 22, 2021
Merged
Conversation
awvwgk
approved these changes
Dec 22, 2021
jvdp1
approved these changes
Dec 22, 2021
jvdp1
left a comment
jvdp1
left a comment
Member
There was a problem hiding this comment.
I approve this PR because it makes all titles using the same rule. However, I would prefer more explicit titles.
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| title: Hash procedures | |||
| title: hash | |||
Member
There was a problem hiding this comment.
Actually I would prefer reading Hash procedures over hash, which is more informative to me.
E..g., Numerical integration can be easier understood than quadrature.
Member
Author
There was a problem hiding this comment.
Why don't we choose whether to list descriptive names or module names and use it consistently? I assumed we were listing module names. Can we merge this as is, and I'll open a new issue to discuss whether to switch this table to descriptive names?
Member
There was a problem hiding this comment.
Yes, merge it as is. At least it is consistent now. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Closes #608.