adds ranges::contains_subrange#1675
Merged
Merged
Conversation
P2302 proposes an `find`-based contains (called `contains`) and a `search`-based contains (called `contains_subrange`). The former is used to determine if an element exists in a range, while the latter is used to determine whether or not a needle range is a subrange of a haystack range.
Contributor
|
Given that LWG has adopted this paper for C++23 it would be nice if this could be added. |
brevzin
approved these changes
Jun 1, 2022
brevzin
reviewed
Jun 2, 2022
| using namespace ranges; | ||
| auto full_range = std::array<int, 10>{0, 1, 2, 3, 4, 5, 6, 7, 8, 9}; | ||
| auto valid_subrange = std::array<int, 5>{2, 3, 4, 5, 6}; | ||
| auto invalid_subrange = std::array<int, 5>{3, 4, 5, 6, 2}; |
Collaborator
There was a problem hiding this comment.
With MSVC, std::array<int, N>::iterator isn't int*, so this test is failing. Can you change these to an int[N] instead? The clang 5 build is failing for reasons that are also basically related to this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2302 proposes an
find-based contains (calledcontains) and asearch-based contains (calledcontains_subrange). The former is usedto determine if an element exists in a range, while the latter is used
to determine whether or not a needle range is a subrange of a
haystack range.