Reduce flatten allocations for subobjects:false#151815
Draft
martijnvg wants to merge 1 commit into
Draft
Conversation
Each intermediate JSON object parsed under subobjects:false previously allocated a FlatteningXContentParser and an anonymous Wrapper to prepend the parent field name to child token names. Thread a String flatPrefix through innerParseObject instead, eliminating two heap allocations per intermediate object on the flatten path.
Member
Author
|
Buildkite benchmark this with elastic-logs-logsdb-columnar |
Collaborator
⏳ Build in-progress
This build attempts two elastic-logs-logsdb-columnar benchmarks to evaluate performance impact of this PR. To estimate benchmark completion time inspect previous nightly runs here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each intermediate JSON object parsed under subobjects:false previously allocated a FlatteningXContentParser and an anonymous Wrapper to prepend the parent field name to child token names. Thread a String flatPrefix through innerParseObject instead, eliminating two heap allocations per intermediate object on the flatten path.