Skip to content

Implement FlowDirection property in ViewHandlers#948

Merged
PureWeen merged 15 commits into
mainfrom
flowdirection-viewhandler
Aug 25, 2021
Merged

Implement FlowDirection property in ViewHandlers#948
PureWeen merged 15 commits into
mainfrom
flowdirection-viewhandler

Conversation

@jsuarezruiz

@jsuarezruiz jsuarezruiz commented May 5, 2021

Copy link
Copy Markdown
Contributor

Description of Change

  • Implement FlowDirection property in ViewHandlers.
  • Don't force the platform to LTR. If the FlowDirection matches the windows FlowDirection then don't set anything on the native platform

Platforms Affected

  • Core
  • iOS
  • macOS
  • Android
  • Windows

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Comment thread src/Core/src/Platform/Android/ViewExtensions.cs Outdated

@rachelkang rachelkang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text is not getting rendered as RTL

Screenshot_1622233079

@PureWeen PureWeen force-pushed the flowdirection-viewhandler branch from e4d02a7 to e56bd94 Compare August 18, 2021 17:39
@PureWeen PureWeen changed the title Implement FlowDirection property in ViewHandlers [WiP] Implement FlowDirection property in ViewHandlers Aug 18, 2021
@PureWeen PureWeen requested a review from rachelkang August 23, 2021 16:27
@PureWeen PureWeen changed the title [WiP] Implement FlowDirection property in ViewHandlers Implement FlowDirection property in ViewHandlers Aug 23, 2021
@PureWeen PureWeen changed the title Implement FlowDirection property in ViewHandlers [WiP] Implement FlowDirection property in ViewHandlers Aug 23, 2021
@PureWeen PureWeen changed the title [WiP] Implement FlowDirection property in ViewHandlers Implement FlowDirection property in ViewHandlers Aug 24, 2021
@PureWeen PureWeen force-pushed the flowdirection-viewhandler branch 3 times, most recently from 29241b3 to c18f0ed Compare August 24, 2021 00:14
@PureWeen PureWeen requested a review from hartez August 24, 2021 01:16
@PureWeen PureWeen force-pushed the flowdirection-viewhandler branch from 6f052e8 to bfebb7a Compare August 24, 2021 19:54
@PureWeen PureWeen force-pushed the flowdirection-viewhandler branch from bfebb7a to f87e6bf Compare August 24, 2021 22:05
@rmarinho rmarinho self-requested a review August 25, 2021 13:18

@rmarinho rmarinho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of issus, some controls don't support RTL.

  • Starting app with Hebrew (RTL language) doesn't show the app in RTL on iOS
  • Forcing RTL on my android Device and starting the app doesnt show the sample app with RTL on

Comment thread src/Controls/src/Core/EffectiveFlowDirectionExtensions.cs Outdated
Comment thread src/Controls/src/Core/HandlerImpl/VisualElement/VisualElement.Impl.cs Outdated
Comment thread src/Controls/src/Core/Layout.cs
Comment thread src/Core/src/Platform/Android/ViewExtensions.cs Outdated
@PureWeen

Copy link
Copy Markdown
Member

@rmarinho logged your findings here
#2255

@PureWeen PureWeen merged commit 377e3f6 into main Aug 25, 2021
@PureWeen PureWeen deleted the flowdirection-viewhandler branch August 25, 2021 19:57
@samhouts samhouts added legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-flyoutpage FlyoutPage area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter area-localization Localization and globalization issues area-navigation NavigationPage area-controls-dialog area-controls-editor Editor area-controls-entry Entry area-controls-flyout Flyout area-controls-label Label, Span area-controls-map Map / Maps area-controls-picker Picker platform/android platform/ios platform/windows labels Jul 11, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-dialog area-controls-editor Editor area-controls-entry Entry area-controls-flyout Flyout area-controls-flyoutpage FlyoutPage area-controls-label Label, Span area-controls-map Map / Maps area-controls-picker Picker area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter area-localization Localization and globalization issues area-navigation NavigationPage fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7! platform/android platform/ios platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants