Skip to content

[UITesting, Catalyst] Fixed DragAndDropUITests to be more reliable#25146

Merged
PureWeen merged 12 commits into
dotnet:mainfrom
NirmalKumarYuvaraj:fix-24914
Dec 9, 2024
Merged

[UITesting, Catalyst] Fixed DragAndDropUITests to be more reliable#25146
PureWeen merged 12 commits into
dotnet:mainfrom
NirmalKumarYuvaraj:fix-24914

Conversation

@NirmalKumarYuvaraj

@NirmalKumarYuvaraj NirmalKumarYuvaraj commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

Description of changes

Developed separate test cases for the DragAndDropBetweenLayouts functionality, each covering individual drag-and-drop operations.

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed

Fixes #24914

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Oct 9, 2024
@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Oct 9, 2024
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@NirmalKumarYuvaraj NirmalKumarYuvaraj marked this pull request as ready for review October 18, 2024 12:02
@NirmalKumarYuvaraj NirmalKumarYuvaraj requested a review from a team as a code owner October 18, 2024 12:02
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz

Copy link
Copy Markdown
Contributor

/rebase

@jsuarezruiz

jsuarezruiz commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

jfversluis
jfversluis previously approved these changes Oct 29, 2024
@jfversluis jfversluis enabled auto-merge (squash) October 29, 2024 11:24
rmarinho
rmarinho previously approved these changes Oct 29, 2024
@jfversluis

Copy link
Copy Markdown
Member

/rebase

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

PureWeen
PureWeen previously requested changes Oct 30, 2024

@PureWeen PureWeen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DropEventCoordinates is failing

@jsuarezruiz jsuarezruiz self-requested a review October 30, 2024 15:11

@jsuarezruiz jsuarezruiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test on Windows:
image

auto-merge was automatically disabled November 1, 2024 07:50

Head branch was pushed to by a user without write access

@Shalini-Ashokan Shalini-Ashokan dismissed stale reviews from rmarinho and jfversluis via 5e485b9 November 1, 2024 07:50
@Shalini-Ashokan

Copy link
Copy Markdown
Contributor

@PureWeen , @jsuarezruiz
It seems the failure is unrelated to the recent changes and is occurring in the helper method. I've added a condition to return null if drag coordinates are unavailable.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis

Copy link
Copy Markdown
Member

/rebase

@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@Shalini-Ashokan

Copy link
Copy Markdown
Contributor

/rebase

@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz

Copy link
Copy Markdown
Contributor

@NirmalKumarYuvaraj Could you rebase and fix the conflict? Thanks in advance.

…o fix-24914

# Conflicts:
#	src/Controls/tests/TestCases.Shared.Tests/Tests/DragAndDropUITests.cs
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis

Copy link
Copy Markdown
Member

/rebase

@NirmalKumarYuvaraj NirmalKumarYuvaraj added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@PureWeen PureWeen dismissed their stale review December 9, 2024 17:21

addressed

@PureWeen

PureWeen commented Dec 9, 2024

Copy link
Copy Markdown
Member
  • failing test not related

@PureWeen PureWeen merged commit a02e7f6 into dotnet:main Dec 9, 2024
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release! partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UITesting, Catalyst] Fix DragAndDropUITests to be more reliable

8 participants