Skip to content

Support [DataMember] IsRequired in NewtonsoftDataContractResolver#2644

Merged
martincostello merged 3 commits into
domaindrivendev:masterfrom
ouvreboite:master
Aug 1, 2024
Merged

Support [DataMember] IsRequired in NewtonsoftDataContractResolver#2644
martincostello merged 3 commits into
domaindrivendev:masterfrom
ouvreboite:master

Conversation

@ouvreboite

@ouvreboite ouvreboite commented May 3, 2023

Copy link
Copy Markdown
Contributor

Resolves #2383

  • Add non-regression tests to ensure [DataMember(IsRequired)] do not bypass existing [JsonObject], [JsonProperty] or [JsonRequired] attributes.
  • Add tests for [DataMember(IsRequired)] and [DataMember(name)]
  • Update NewtonsoftDataContractResolver to directly leverage jsonProperty.Required, instead of using the IsRequiredSpecifed extension method

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DataMember(IsRequired = true)] do not mark property as required

3 participants