Introspect default expressions as DefaultExpression#7275
Merged
Conversation
Member
Author
|
The test failures are being fixed in #7276. |
greg0ire
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7274.
This is a backport of the corresponding logic from #7197.
The idea is that
AbstractSchemaManagerimplementations should not invokeAbstractPlatform::getCurrent*SQL(), the return value of which would match the expression string and trigger a deprecation. Instead, they should instantiate the correspondingDefaultExpressioninstance.I haven't found an existing test where I could put a "no deprecation triggered" assertion, and I don't feel like writing a throwaway one. This is how the the changes can be formally verified: