Fixed missing mapping of required attributes if property is nillable#1887
Merged
Merged
Conversation
stephanr
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the Gml Tools SqlFeatureStoreConfigCreator the mapping of required attributes is missing if a property is nilled.
Example from https://inspire.ec.europa.eu/schemas/bu-core2d/4.0/BuildingsCore2D.xsd:
uom is a required attribute but missing in the resulting mapping:;
The referenceData contains the property:
This PR fixes the Gml Tool by writing the mapping of required attributes even if the property is nilled: