Skip to content

JAXB v3#1457

Closed
KevinvdBosch wants to merge 4 commits into
deegree:mainfrom
IDgis:jaxb_v3
Closed

JAXB v3#1457
KevinvdBosch wants to merge 4 commits into
deegree:mainfrom
IDgis:jaxb_v3

Conversation

@KevinvdBosch

Copy link
Copy Markdown
Contributor

This pull request contains changes from using jaxb v2 to v3. This means converting the use of javax packages to jakarta.

The only problem with this is that xsd files can't be found anymore when they are in separate modules. It seems that maven can't merge them properly anymore.

A temporary fix could be to duplicate the xsd files where needed. This will make all unit tests pass.

The only thing that still remains broken is the creation of the zip file containing all schema files in the deegree-core-schema module.

depends on #1452

@stephanr

Copy link
Copy Markdown
Member

The only problem with this is that xsd files can't be found anymore when they are in separate modules. It seems that maven can't merge them properly anymore.

Could this be related to our custom resolver configured here:

<catalogResolver>org.deegree.uncoupled.jaxb.CatalogResolver</catalogResolver>

Have you checked whether this interface also needs to be changed?

public class CatalogResolver extends com.sun.org.apache.xml.internal.resolver.tools.CatalogResolver {

@tfr42 tfr42 added the CI failing CI build job fails label Jan 23, 2023
@tfr42

tfr42 commented Jan 23, 2023

Copy link
Copy Markdown
Member

Hi @KevinvdBosch, thank you for providing that PR.
To make it easier to merge the proposed changes would it be possible that you

@tfr42 tfr42 mentioned this pull request Jan 23, 2023
4 tasks
@tfr42 tfr42 added this to the 3.6 milestone Feb 8, 2023
@lgoltz lgoltz added the needs rebase PR is not up to date and needs rebase label May 13, 2023
@tfr42 tfr42 closed this in #1605 Dec 1, 2023
@tfr42 tfr42 added duplicate and removed needs rebase PR is not up to date and needs rebase CI failing CI build job fails labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants