Optimization of vendor-specific rendering of a graphic on a line#1423
Merged
copierrj merged 8 commits intoNov 16, 2022
Merged
Conversation
…into enhancement/graphic-stroke-with-point-199-1204
…' and 'deegree-graphicstroke-rotation' add deprecation warning for the Element 'PositionPercentage'
…nd rotation in relation to the line
stephanr
added
enhancement
stephanr
changed the title
…troke-with-point-199-1204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the changed described/discussed in #1418 an is a small part of #1204 (replaces
AnchoredSymbol)Includes #1405 as it requires its fixes to the SVG for tests
Extends the unit test introduced with #1420
The following changed to
GraphicStrokeare made:deegree-graphicstroke-rotationdeegree-graphicstroke-position-percentagePositionPercentagewill still be parsered but creates a warning in the logfileAnchorPointandDisplacementcan now be used for SVG and Mark and imagesGraphic/ExternalGraphic/OnlineResource) or like Mark (Graphic/Mark/OnlineResource)deegree.rendering.graphicstroke.svg-as-markCloses #1418