Skip to content

Fixed handling of svgs in PolygonSymbolizer#1095

Merged
copierrj merged 2 commits into
deegree:mainfrom
lat-lon:polygonSymbolizerFillWithSvg-1093
Sep 21, 2022
Merged

Fixed handling of svgs in PolygonSymbolizer#1095
copierrj merged 2 commits into
deegree:mainfrom
lat-lon:polygonSymbolizerFillWithSvg-1093

Conversation

@lgoltz

@lgoltz lgoltz commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Fixes #1093

@tfr42 tfr42 added the bug error issue and bug (fix) label Oct 30, 2020
@lgoltz lgoltz force-pushed the polygonSymbolizerFillWithSvg-1093 branch from 9de04a1 to 793b645 Compare November 16, 2020 13:39
@lgoltz

lgoltz commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

Verified by user.

@tfr42 tfr42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports shall be explicit, not java.awt.*

@copierrj

Copy link
Copy Markdown
Member

Question: what happens when another image format (like png) is used instead of svg?

@lgoltz

lgoltz commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Imports shall be explicit, not java.awt.*

Fixed

@lgoltz

lgoltz commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Question: what happens when another image format (like png) is used instead of svg?

Images in other formats than svg are read during parsing:

if ( pair.first != null && format != null && ( format.toLowerCase().indexOf( "svg" ) == -1 ) ) {
img = ImageIO.read( pair.first );
}

The enhancements applies only if graphic.image == null (in case of svgs and marks).

@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label May 16, 2022
@tfr42 tfr42 removed the needs rebase PR is not up to date and needs rebase label Sep 7, 2022
@tfr42 tfr42 added the WMS deegree Web Map Service label Sep 14, 2022
@tfr42 tfr42 added this to the 3.5 milestone Sep 14, 2022
@tfr42 tfr42 self-requested a review September 14, 2022 15:22
@copierrj copierrj merged commit 62e8a7a into deegree:main Sep 21, 2022
@lgoltz lgoltz deleted the polygonSymbolizerFillWithSvg-1093 branch December 8, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug error issue and bug (fix) WMS deegree Web Map Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

svg in PolygonSymbolizer is ignored

3 participants