fix: stale hardcoded version in health check, deprecated API, typos - #908
Open
fix2015 wants to merge 1 commit into
Open
fix: stale hardcoded version in health check, deprecated API, typos#908fix2015 wants to merge 1 commit into
fix2015 wants to merge 1 commit into
Conversation
- healthCheck() was returning hardcoded version '2.24.1' instead of the actual package version. imported PROJECT_VERSION and used that instead. - res.finished was deprecated in Node 13, changed to res.writableEnded - fixed "paralel" → "parallel" and "Concieved" → "Conceived" in CLAUDE.md - replaced dead issue link (issues/XXX) with inline description - removed unnecessary (this as any) cast in workflow-validator since currentWorkflow is already properly typed on the class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things I spotted: