feat(elasticache): support inplace migration to valkey engine#2293
Open
Kunalbehbud wants to merge 1 commit into
Open
feat(elasticache): support inplace migration to valkey engine#2293Kunalbehbud wants to merge 1 commit into
Kunalbehbud wants to merge 1 commit into
Conversation
Signed-off-by: kunal.behbudzade <kunal.behbudzade@btsgrp.com>
Author
|
Leaving a ping here in case this fell through the cracks. Happy to adjust the Valkey migration behavior or test coverage if there are concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2290
This PR adds support for in-place ElastiCache ReplicationGroup migration from Redis to Valkey.
It makes
spec.forProvider.enginemutable, updates the ElastiCache client logic to passEnginethroughModifyReplicationGroupInput, and extends update detection so engine changes are reconciled correctly. It also updates the AWS SDK dependency to a version that exposes the ElastiCache Valkey support needed by this flow.Checklist
ModifyReplicationGroupInputincludesEnginemake testsuccessfully