cloud-providers: Generate provider configs with all options uncommented

[Hru-s]

Summary

• Fixes Generate provider config templates with all options uncommented by default #2856
• Changed gen-provider-values jq script in src/cloud-providers/Makefile to emit all config keys as real YAML keys instead of comments
• Removed the empty map {} fallback for providers with no required flags
• Regenerated all 10 provider YAML files under install/charts/peerpods/providers/
• Manually updated vsphere.yaml (no manager.go in current source tree)

Problem

Non-required flags were emitted as YAML comments (e.g. # LIBVIRT_MEMORY: "8192") and providers without required flags got providerConfigs.<name>: {}. This caused providerConfigs to be treated as nil in some tooling (notably the Terraform Helm provider), breaking --set-literal overrides on keys under that section.

Solution

Two lines changed in the Makefile's jq script:

1. Always emit <provider>: (never <provider>: {})
2. Emit non-required flags as real keys (remove # prefix)

Why this is safe

• All default values match the Go hardcoded defaults (verified with config-extractor)
• Empty strings are handled gracefully by the Go code
• The _helpers.tpl hasTlsCerts check remains safe: CACERT_FILE: "" is falsy in Go templates, so TLS mounts only trigger when the user sets a real certificate path

Test results

Test	Result
No {} in any provider YAML	PASS
No commented-out config keys	PASS
All 10 YAMLs parse with non-empty providerConfigs	PASS
All required flags are real YAML keys	PASS
No drift after regeneration	PASS
helm lint passes for all 10 providers	PASS
helm template renders correct ConfigMaps for all 10 providers	PASS
--set-literal override works for libvirt (original bug)	PASS
--set-literal override works for AWS	PASS
TLS mount NOT triggered with empty CACERT_FILE	PASS
TLS mount triggered with real CACERT_FILE path	PASS
Docker socket mount present for docker provider	PASS
SSH mount present for libvirt provider	PASS
kata-direct-volumes mount present for ibmcloud provider	PASS
Go defaults == YAML defaults for all 9 auto-generated providers	PASS

[beraldoleal]

hey @Hru-s , thank you.

Please rebase so we can run the tests.

[ldoktor]

I remember hitting this issue as well. IIUC you changed only the Makefile and then ran the make sync-chart-values to update the yaml files? Anyway lgtm but needs rebase.