Skip to content

chore: remove KVM/VM host (pods) support - #511

Merged
r00ta merged 20 commits into
canonical:masterfrom
r00ta:remove-vmhosts
Jul 30, 2026
Merged

chore: remove KVM/VM host (pods) support#511
r00ta merged 20 commits into
canonical:masterfrom
r00ta:remove-vmhosts

Conversation

@r00ta

@r00ta r00ta commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

KVM/VM hosts (pods), VM clusters, and machine composition are removed from MAAS. The related REST and websocket endpoints are kept as stubs returning HTTP 410 Gone so that existing API clients get a clear signal instead of a 404, and the install_kvm/register_vmhost deploy parameters are rejected with 400 Bad Request.

Existing LXD and virsh virtual machines remain power-controllable: the lxd and virsh drivers are reintroduced as plain chassis-capable power drivers, so VMs registered before the upgrade keep working as regular machines.

Database changes:

  • 0036 drops install_kvm/register_vmhost from maasserver_node
  • 0037 drops the pod-only maasserver_bmc columns, the virtualmachine*, podhints, podstoragepool and vmcluster tables, the maasserver_podhost view, and the pod/vmcluster notification triggers
  • 0038 normalises leftover bmc_type=POD rows to plain BMCs, preserving the power configuration of existing VMs

Also removed: pod forms and RPC operations, KVM vendor-data generation for machine deployment, pod/vmcluster websocket handlers, VM host, Prometheus metrics and stats, and the corresponding documentation.

@r00ta
r00ta marked this pull request as ready for review July 27, 2026 08:11
@r00ta
r00ta requested a review from a team July 27, 2026 08:12
Comment thread src/provisioningserver/drivers/power/lxd.py
@r00ta
r00ta requested a review from Copilot July 27, 2026 15:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@r00ta r00ta changed the title chore: remove pods/vm hosts [WIP] chore: remove pods/vm hosts Jul 27, 2026
@r00ta r00ta changed the title [WIP] chore: remove pods/vm hosts chore: remove pods/vm hosts Jul 27, 2026
@r00ta r00ta changed the title chore: remove pods/vm hosts chore: remove KVM/VM (pods) support Jul 28, 2026
@r00ta

r00ta commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

QA already performed:

  • install 3.8/stable
  • register a kvm host
  • compose 2 vms
  • upgrade to this patch
  • the machines are still visible and properly working (they can be commissioned/deployed and so on)

General tests with the UI canonical/maas-ui#6114

@r00ta r00ta changed the title chore: remove KVM/VM (pods) support chore: remove KVM/VM host (pods) support Jul 28, 2026
Comment thread src/maasserver/api/examples/nodes.json
Comment thread src/maasserver/api/examples/machines.json
Comment thread src/maasserver/api/examples/tags.json
Comment thread src/maasserver/api/tests/test_enlistment.py
Comment thread src/maasserver/api/machines.py
Comment thread src/maasserver/api/pods.py
Comment thread src/maasserver/models/discovery.py
Comment thread src/maasserver/models/node.py
Comment thread src/maasservicelayer/db/repositories/nodes.py
Comment thread src/maasserver/utils/certificates.py
skatsaounis
skatsaounis previously approved these changes Jul 29, 2026

@skatsaounis skatsaounis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@skatsaounis skatsaounis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM after the rebase

@r00ta
r00ta enabled auto-merge July 30, 2026 10:42
@r00ta
r00ta added this pull request to the merge queue Jul 30, 2026
Merged via the queue into canonical:master with commit 08f65b9 Jul 30, 2026
9 checks passed
@tmerten

tmerten commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants