[codex] Add World Cup soccer data sources#740
Draft
arsalann wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the selected World Cup soccer data source work for API-Football, BallDontLie FIFA, and football-data.org.
api-football://for teams, stadiums, group standings, matches, players, and match events.balldontlie-fifa://with documented World Cup tables, cursor pagination, nested-object flattening, and clearer auth/plan-access errors.football-data://for teams, derived stadiums, group standings, matches, squad-derived players, and unfolded match events.Notes
teamsandstadiums;group_standingsreturned plan-gated401.teams,matches,group_standings,stadiumswith zero current venue rows,match_eventswith zero current event rows, andplayers --sql-limit=1; full players hit provider429during team hydration.Validation
go test ./pkg/source/api_football ./pkg/source/balldontlie_fifa ./pkg/source/football_data_orggo test -short ./...npm run docs:buildPATH="$(go env GOPATH)/bin:$PATH" make lint-ciSelf-review
docs/soccer-sources/handoff.mdrather than hiding them in implementation details.