Included value of Accept header in Vary header generated for get requ… - #3516
Merged
hughrun merged 1 commit intoMar 16, 2025
Conversation
…ests with differing behaviors based on Accept
Member
|
Thankyou! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ests with differing behaviors based on Accept
Description
This pull request adds the value of the HTTP Accept header to the generated Vary header for
GETrequests that behave differently based on the value of Accept -- generally pages that return HTML or JSON based on the value of Accept. This is in support of external caching in front of Nginx, as described in #3512 .I did not modify the Vary header behavior for any
POSTendpoints because I am not familiar enough to know which are idempotent.Varyheader should includeAcceptif a resource can be HTML and JSON #3512What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Documentation
Tests