Ignore ClosedByteChannelException in CalendarFetcher#701
Merged
sunkup merged 2 commits intoSep 11, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses server misbehavior by gracefully handling ClosedByteChannelException in the calendar fetching process. The exception occurs when servers send more bytes than expected, causing protocol errors that should be ignored rather than propagated as failures.
- Adds exception handling for
ClosedByteChannelExceptionto prevent crashes from server protocol violations - Logs the ignored exception for debugging purposes while allowing the application to continue
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ArnyminerZ
approved these changes
Sep 11, 2025
ArnyminerZ
left a comment
ArnyminerZ
left a comment
Member
There was a problem hiding this comment.
Okay, sounds fair enough. Feel free to merge
sunkup
deleted the
700-ignore-closedbytechannelexception-and-protocolexception
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Ignore ClosedByteChannelException which is thrown ProtocolException is thrown which happens when when servers misbehave and for example send more bytes than expected.
Short description
ClosedByteChannelExceptionChecklist