fix reference link regex#31
Merged
Merged
Conversation
benbalter
approved these changes
Sep 22, 2017
Owner
|
Nice catch. Thanks for this @qwtel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short version: fixed a bug I introduced that breaks sites with reference links
Long version: Regexes work differently in JavaScript (which I know) and Ruby.
In JS,
\smatches all whitepace, but not newlines. However, in ruby (and I think most languages) newlines are included. That, in combination with not using the non-greedy*?quantifier caused all newlines in front of a reference link to be replaced, resulting in invalid reference links, e.g. [test].[test]: http://github.com